Skip to content

Conversation

@qqmyers
Copy link
Member

@qqmyers qqmyers commented Feb 27, 2025

What this PR does / why we need it: This implements a proxy in Dataverse to handle calls from an external vocab script to the Local Contexts Hub server to implement Indigenous Data support/show notices and labels about the dataset that are managed on the LC Hub.

Which issue(s) this PR closes:

  • Closes #

Special notes for your reviewer:

Suggestions on how to test this: Follow the directions at https://github.com/gdcc/dataverse-external-vocab-support/tree/main/packages/local_contexts. I have an API key that can be used with their sandbox.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

Preview at https://dataverse-guide--11294.org.readthedocs.build/en/11294/user/appendix.html

@coveralls
Copy link

coveralls commented Mar 5, 2025

Coverage Status

coverage: 23.211% (-0.005%) from 23.216%
when pulling 29cbca9 on GlobalDataverseCommunityConsortium:TKLabels
into a9872c9 on IQSS:develop.

@qqmyers qqmyers moved this to Ready for Triage in IQSS Dataverse Project Apr 10, 2025
@qqmyers qqmyers marked this pull request as ready for review April 10, 2025 20:20
@ofahimIQSS ofahimIQSS moved this from Ready for Triage to Ready for Review ⏩ in IQSS Dataverse Project Apr 15, 2025
@cmbz cmbz added the GREI 5 Use Cases label Apr 15, 2025
@cmbz cmbz added FY25 Sprint 21 FY25 Sprint 21 (2025-04-09 - 2025-04-23) FY25 Sprint 22 FY25 Sprint 22 (2025-04-23 - 2025-05-07) labels Apr 23, 2025
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged conflicts have been resolved and API tests are passing. The rest (how to test, release note) can be figured out in QA. Approved.

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Jun 24, 2025
@ofahimIQSS ofahimIQSS self-assigned this Jun 24, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Jun 24, 2025
@ofahimIQSS
Copy link
Contributor

When I push this PR to internal from Jenkins - I get stuck on the Payara screen. Server log attached
inserver.log

MicroProfile Config: property 'dataverse.db.password': no value found, no default given.

@qqmyers
Copy link
Member Author

qqmyers commented Jun 25, 2025

This PR has nothing to do with dataverse.db.password . I also think it's likely that the warning you show has been there all along and is non-fatal. (Guessing internal is configured to not need it).

Looking at the log on internal, it looks like the problem is the flyway conflict that has been discussed in slack - due to the 6.6.0.1 script being deployed and then, in a later PR, being renamed as 6.6.0.2 with a new 6.6.0.1 added by another PR. Hopefully the standard procedure to address flyway conflicts will get you going.

@ofahimIQSS
Copy link
Contributor

ran continuous integration twice but it failed with ansible error :(

@ofahimIQSS
Copy link
Contributor

Looks good from my end - merging.

image
image

@ofahimIQSS ofahimIQSS merged commit 5781291 into IQSS:develop Jun 27, 2025
15 of 16 checks passed
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Jun 27, 2025
@ofahimIQSS ofahimIQSS removed their assignment Jun 27, 2025
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Jun 30, 2025
@cmbz cmbz added the FY26 Sprint 1 FY26 Sprint 1 (2025-07-02 - 2025-07-16) label Jul 2, 2025
@cmbz cmbz added the FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) label Aug 16, 2025
pdurbin added a commit that referenced this pull request Sep 5, 2025
…abelDocUpdate

TKLabel flag not documented in #11294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY25 Sprint 21 FY25 Sprint 21 (2025-04-09 - 2025-04-23) FY25 Sprint 22 FY25 Sprint 22 (2025-04-23 - 2025-05-07) FY25 Sprint 23 FY25 Sprint 23 (2025-05-07 - 2025-05-21) FY25 Sprint 24 FY25 Sprint 24 (2025-05-21 - 2025-06-04) FY25 Sprint 25 FY25 Sprint 25 (2025-06-04 - 2025-06-18) FY25 Sprint 26 FY25 Sprint 26 (2025-06-18 - 2025-07-02) FY26 Sprint 1 FY26 Sprint 1 (2025-07-02 - 2025-07-16) FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) GREI 5 Use Cases Size: 10 A percentage of a sprint. 7 hours.

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

5 participants