-
Notifications
You must be signed in to change notification settings - Fork 531
TKLabels v2 implementation #11294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TKLabels v2 implementation #11294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged conflicts have been resolved and API tests are passing. The rest (how to test, release note) can be figured out in QA. Approved.
Co-authored-by: Omer Fahim <[email protected]>
Co-authored-by: Philip Durbin <[email protected]>
|
When I push this PR to internal from Jenkins - I get stuck on the Payara screen. Server log attached MicroProfile Config: property 'dataverse.db.password': no value found, no default given. |
|
This PR has nothing to do with dataverse.db.password . I also think it's likely that the warning you show has been there all along and is non-fatal. (Guessing internal is configured to not need it). Looking at the log on internal, it looks like the problem is the flyway conflict that has been discussed in slack - due to the 6.6.0.1 script being deployed and then, in a later PR, being renamed as 6.6.0.2 with a new 6.6.0.1 added by another PR. Hopefully the standard procedure to address flyway conflicts will get you going. |
|
ran continuous integration twice but it failed with ansible error :( |
…abelDocUpdate TKLabel flag not documented in #11294


What this PR does / why we need it: This implements a proxy in Dataverse to handle calls from an external vocab script to the Local Contexts Hub server to implement Indigenous Data support/show notices and labels about the dataset that are managed on the LC Hub.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this: Follow the directions at https://github.com/gdcc/dataverse-external-vocab-support/tree/main/packages/local_contexts. I have an API key that can be used with their sandbox.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation:
Preview at https://dataverse-guide--11294.org.readthedocs.build/en/11294/user/appendix.html